Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/opencrypto

On Sun, 19 Jan 2014, Christos Zoulas wrote:

On Jan 19,  3:04pm, (Paul Goyette) wrote:
-- Subject: Re: CVS commit: src/sys/opencrypto

| The mere existence of a non-zero unit is a "reference" that needs to
| prevent unloading.

What if it is the last reference? Then the ref count will go to zero after
close without unloading, and you'll never unload.

| The two checks (unit# and ref-count) are equivalent and redundant, and
| only one of them needs to be there.

Well, just keep the refcount one then.

Yup - that's what I committed.

The device_t wasn't available anyway, in crypto_modcmd()   :)

| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
| Kernel Developer |                          | pgoyette at  |

Home | Main Index | Thread Index | Old Index