Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/opencrypto

On Sun, 19 Jan 2014, Christos Zoulas wrote:

On Jan 19, 10:37am, (Paul Goyette) wrote:
-- Subject: Re: CVS commit: src/sys/opencrypto

| That's covered in cryptoopen() at line 1060

I missed that patch

No worry.

| Handled indirectly.  The MODULE_CMD_FINI calls config_cfdata_detach()
| which attempts to detach each device instance.  If a detach fails, then
| config_cfdata_detach fails, and the unload will fail.

Ok then! Did you test it? If it works, I guess commit it.

It does address the simple case I described. It has a minor/cosmetic issue of printing an error message

        crypto0: unable to detach instance

from config_cfdata_detach().

But David Laight's post has me more concerned, that perhaps we really need to solve this sort of issue more generically.

So, not sure if this should be committed, or if we should leave your code in to prevent unload in all cases.

| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
| Kernel Developer |                          | pgoyette at  |

Home | Main Index | Thread Index | Old Index