Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/luna68k/dev

christos@ wrote:

> On Jan 2,  1:25pm, (Izumi Tsutsui) wrote:
> -- Subject: Re: CVS commit: src/sys/arch/luna68k/dev
> | > This could lead to problems in the future. I would put it back.
> | 
> |  - it was added by me recently
> |  - netbsd-6 doesn't have it
> |  - no other serial driver except com(4) has it
> I don't know, if nothing uses it, it is not needed, if things start
> using it, it should be initialized everywhere.

Then you shouldn't put it back unless you know how it will be used.

There was no explanation why it was needed in related commit logs,
and if it's really necessary in all drivers it was an API change
and should be announced properly.

Anyway I don't see reason why it's necessary.
All other tty drivers use device_lookup_private(9) with
struct cfdriver and UNIT(tp->t_dev) to get softc in drivers.

Izumi Tsutsui

Home | Main Index | Thread Index | Old Index