Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src

Lourival Pereira Vieira Neto wrote:
> Module Name:  src
> Committed By: lneto
> Date:         Mon Dec  2 06:07:22 UTC 2013
> Modified Files:
>       src/external/mit/lua/dist/src: luaconf.h
>       src/sys/modules/lua: Makefile
> Removed Files:
>       src/sys/modules/lua: luaconf.h
> Log Message:
> merged luaconf.h of kernel and userspace Lua

1. This doesn't look right:

#define luai_numpow(a,b)        luai_nummul(a,b)                                

2. If intmax_t is a greater type than int64_t, the below doesn't
handle overflow:
#define lua_str2number(s,p)    ((int64_t) strtoimax((s), (p), 10))

I checked Lua code and there is no overflow check. However, I noticed
that they detect "0x" strings and convert them using strtoul. It should
be changed to stroumax. This is in function luaO_str2d in src/lobject.c.

3. Item 1 was in my earlier review of luaconf.h in sys/modules and I see
at least one minor item not covered by your new change. Can you please 
go over my review and make sure all covered?


Home | Main Index | Thread Index | Old Index