Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys

On Sat, 23 Nov 2013, Jeff Rizzo wrote:
Log Message:
Since mountlist is now a TAILQ, convert some missed usages
so things build again.

It would be better if the callers were rewritten to use the queue.h macros instead of direct access to the struct members. (Especially since the names of the struct members are not part of the documented API.)

For example, this ...

-    for (mp = mountlist.cqh_first; mp != (void*)&mountlist; mp = nmp) {
-       nmp = mp->mnt_list.cqe_next;
+    for (mp = mountlist.tqh_first; mp != (void*)&mountlist; mp = nmp) {
+       nmp = mp->mnt_list.tqe_next;

... could be rewritten to use TAILQ_FOREACH.

--apb (Alan Barrett)

Home | Main Index | Thread Index | Old Index