Re: CVS commit: src/sys/net/npf

[Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>]

Paul Goyette <paul%whooppee.com@localhost> wrote:
> On Tue, 29 Oct 2013, Mindaugas Rasiukevicius wrote:
> 
> > Module Name:        src
> > Committed By:       rmind
> > Date:               Tue Oct 29 16:39:10 UTC 2013
> >
> > Modified Files:
> >     src/sys/net/npf: npf_impl.h npf_nat.c npf_session.c
> >
> > Log Message:
> > npf_session_setnat: fix the race condition when the old connection is
> > still being expired while a new/duplicate is being created.
> 
> Should we have (or do we have) a regression test to catch this race 
> condition?

You would need to write a test simulating a particular condition and then
trying to brute-force the race.  It requires a bit of coding as it is not
an easy race to trigger.  Let me know if you want to volunteer.

-- 
Mindaugas