Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/distrib/utils/embedded

On Sun, Sep 15, 2013 at 02:05:59PM -0400, Christos Zoulas wrote:
> On Sep 15,  5:59pm, (Adrian Steinmann) wrote:
> -- Subject: Re: CVS commit: src/distrib/utils/embedded
> | On Sun, Sep 15, 2013 at 01:26:51PM +0000, Christos Zoulas wrote:
> | > In article <>,
> | > Adrian Steinmann <> wrote:
> | > 
> | > 1. This is useless in the .conf files since mkimage sets it alreay.
> | > >+GZIP_CMD=${TOOL_GZIP:-gzip} # ${GZIP} is special to gzip(1)
> | Well yes, but it is not said that this config file might eventually
> | be pulled in by something else not defining TOOL_GZIP. I could have
> | indeed left the naked "gzip" in there, but I would think that when
> | TOOL_GZIP is defined, it is what should be used.  In other words,
> | I thought about it a bit and found this to be the best choice.
> Yes, so go ahead and define all the other variables those scripts
> assume that are set, like "release" "srcs" etc. Preferably with a
> different definition than the one we have in mkimage to make
> debugging more interesting. There is a reason those are called .conf;
> they are not and they were not meant to be standalone -- by design.
> Duplicating definitions should be always the solution of last resort.

So you're suggesting I remove the

GZIP_CMD=${TOOL_GZIP:-gzip} # ${GZIP} is special to gzip(1)

line and just use

    ${TOOL_GZIP} -dc "${bbone_kernel}" > "${mnt}/boot/${bbone_kernelimg}"

further below in beagleboard.conf, rpi.conf, and rpi_inst.conf ?

By that logic we should have also used ${TOOL_GZIP} for gzip instead
of the ${GZIP} indirection in mkimage which started this thread and
was actually causing a problem.

Tell me what you think is best.


Home | Main Index | Thread Index | Old Index