Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: [riastradh-drm2] src/sys/external/bsd/drm2/include/linux

On Wed, 24 Jul 2013, Taylor R Campbell wrote:
Module Name:    src
Committed By:   riastradh
Date:           Wed Jul 24 01:54:19 UTC 2013

Modified Files:
        src/sys/external/bsd/drm2/include/linux [riastradh-drm2]: types.h

Log Message:
Define cycles_t to be unsigned long long for now in <linux/types.h>.

Could we use a fixed-size type?  Perhaps uint64_t?

If this type is never exposed to userland then it doesn't matter, but if it is exposed to userland then a fixed-size type makes it easier to provide compatibility between 32-bit and 64-bit versions of related platforms. i386 and amd64 both have 64-bit long long, so it doesn't affect them, but other pairs of related platforms (perhaps in the future) might be different.

--apb (Alan Barrett)

Home | Main Index | Thread Index | Old Index