Re: CVS commit: src

[yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)]

> On Wed, Apr 17, 2013 at 06:32:30AM +0000, YAMAMOTO Takashi wrote:
>> > Module Name:       src
>> > Committed By:      joerg
>> > Date:              Tue Apr 16 21:44:08 UTC 2013
>> > 
>> > Modified Files:
>> >    src/common/lib/libc/stdlib: _strtol.h _strtoul.h strtoll.c strtoull.c
>> >        strtoumax.c
>> >    src/include: inttypes.h stdlib.h
>> >    src/lib/libc: shlib_version
>> >    src/lib/libc/citrus: citrus_bcs_strtol.c citrus_bcs_strtoul.c
>> >    src/lib/libc/include: namespace.h
>> >    src/lib/libc/stdlib: strtoimax.c
>> > 
>> > Log Message:
>> > Add strtol_l and friends. Switch _citrus_bcs_strtol to use plain
>> > strtol_l unless in tools mode. Add note to retire the BCS code on the
>> > next libc major bump.
>> 
>> is it safe to make tools use host's strtoul?
> 
> I think so. Tools shouldn't be using locales.

as you know, use C locale != stop using locale.
i don't know if it can be an actual problem for netbsd as we likely
have other code which assumes PCS compatibility between host and netbsd,
though.  on the other hand, this code is intended to be portable than
the rest of libc because there's a plan to create a portable version of
citrus iconv library.
you'd be better to ask the author (tnozaki) to clarify the intention of
the code before simplifying it.

YAMAMOTO Takashi

> 
> Joerg