Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/netinet

"Christos Zoulas" <> writes:

> Module Name:  src
> Committed By: christos
> Date:         Tue Mar 12 21:54:36 UTC 2013
> Modified Files:
>       src/sys/netinet: in4_cksum.c
> Log Message:
> - Don't panic on short packets unless DIAGNOSTIC. In general we should try
>   to make the kernel survive errors...

This seems odd.  Either there's an invariant that there can't be a short
packet, or there isn't.  DIAGNOSTIC is basically supposed to add checks
for invariants, but that's not about not crashing on not DIAGNOSTIC but
avoiding the run-time costs of the checks.
So is a short packet a "can't happen" case?

Attachment: pgpW_Ragm4cOh.pgp
Description: PGP signature

Home | Main Index | Thread Index | Old Index