Re: CVS commit: src/sys/arch/evbarm/conf

[christos%astron.com@localhost (Christos Zoulas)]

In article <51176DC1.7040902%netbsd.org@localhost>,
Nick Hudson  <skrll%netbsd.org@localhost> wrote:
>On 02/09/13 20:48, Christos Zoulas wrote:
>>
>>
>> Modified files:
>>
>> Index: src/sys/arch/evbarm/conf/mk.rpi
>> diff -u src/sys/arch/evbarm/conf/mk.rpi:1.2
>src/sys/arch/evbarm/conf/mk.rpi:1.3
>> --- src/sys/arch/evbarm/conf/mk.rpi:1.2      Mon Dec 10 00:02:14 2012
>> +++ src/sys/arch/evbarm/conf/mk.rpi  Sat Feb  9 15:48:38 2013
>> @@ -1,4 +1,4 @@
>> -#   $NetBSD: mk.rpi,v 1.2 2012/12/10 05:02:14 matt Exp $
>> +#   $NetBSD: mk.rpi,v 1.3 2013/02/09 20:48:38 christos Exp $
>>   
>>   CPPFLAGS+= -march=armv6z -mtune=arm1176jzf-s -mfpu=vfp
>>   
>> @@ -13,5 +13,7 @@ KERNEL_BASE_PHYS=0x00008000
>>   KERNEL_BASE_VIRT=0xc0008000
>>   
>>   SYSTEM_LD_TAIL_EXTRA+=; \
>> -    echo ${OBJCOPY} -S -O binary $@ kernel.img; \
>> -    ${OBJCOPY} -S -O binary $@ kernel.img
>> +    echo ${OBJCOPY} -S -O binary $@ $@.bin; \
>> +    ${OBJCOPY} -S -O binary $@ $@.bin
>> +
>> +EXTRA_KERNELS+= ${KERNELS:@.KERNEL.@${.KERNEL.}.bin@}
>>
>Why is this change necessary / good?

1. Because being different breaks the installation rules for the kernels.
   (Would need to add .img to the files that get copied to the installation
    area, plus hack to recognize "kernel" as a valid file to copy). And once
   it gets copied there, having a generic name next to the other boards does
   not make sense.
2. Because what happens when you have more than one RPI kernel configuration
   (one with and one without ethernet let's say)
3. Because I needed to do it in order to hook the mkimage stuff to the regular
   build.

Anyway, if you figure out a better way to do this, go ahead.

christos