Re: CVS commit: src/sys/kern

[Warner Losh <imp%bsdimp.com@localhost>]

On Jan 30, 2013, at 1:07 AM, David Laight wrote:

> On Tue, Jan 29, 2013 at 11:00:31PM +0000, Lars Heidieker wrote:
>> Module Name: src
>> Committed By:        para
>> Date:                Tue Jan 29 23:00:31 UTC 2013
>> 
>> Modified Files:
>>      src/sys/kern: kern_sysctl.c
>> 
>> Log Message:
>> fix the sysctl_setup_func typedef
> 
> -typedef void (*sysctl_setup_func)(struct sysctllog **);
> +typedef void sysctl_setup_func(struct sysctllog **);
> 
> IIRC you are only supposed to be able to typedef pointers to functions.

It is totally legal, and has been for three decades or so...

> The extra level of indirection (that caused the horrid casting)
> is elsewhere.
> (I wasn't at all sure the previous 'fix' was right.)
> 
>       David
> 
> -- 
> David Laight: david%l8s.co.uk@localhost