Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/lib/libkern

On Wed, Jan 23, 2013 at 10:34:38PM +0000, Matt Thomas wrote:
> Module Name:  src
> Committed By: matt
> Date:         Wed Jan 23 22:34:37 UTC 2013
> Modified Files:
>       src/sys/lib/libkern: Makefile.libkern
>       src/sys/lib/libkern/arch/arm:
> Log Message:
> Add strnlen.c to SRCS (which will automatically use the .S version if it
> exists).

Please don't do that.  You should add strnlen.S

At some point the makefiles ought to be changed so that the .o depends
explicitly on the relevant source file (be it .c .S or something else)
rather than relying on make's 'hunt for a source file' suffix rules.

Doing that would make it much easier for some sub-architectures to
fall back on the .c version even when a .S one exists (but, for example,
uses unavailable instructions).


David Laight:

Home | Main Index | Thread Index | Old Index