Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.sbin/envstat

On Fri, 14 Dec 2012, Jukka Ruohonen wrote:

On Thu, Dec 13, 2012 at 11:53:24AM -0800, Paul Goyette wrote:
While we're making sure to free() things, should we not also defend
against memory leaks in the case where an option is used more than once?

While we are here, I wonder why sysmon(9) does not follow the common
guidelines w.r.t. for instance queue(3). I know quite well that none of
this is your making, but smalll refactorings like this could make the code
more understandable to other people.

There's lots of clean-up work to do here. Yes, it needs to be done, but I just haven't had the time or energy to dive into it deep enough!

I promise, I will get to it.  I just can't promise when.   :)

| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
| Kernel Developer |                          | pgoyette at  |

Home | Main Index | Thread Index | Old Index