Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch

On Mon, 10 Dec 2012, David Holland wrote:

On Sun, Dec 09, 2012 at 11:27:14AM -0600, David Young wrote:
> > Modified Files:
> >       src/sys/arch/i386/i386: db_interface.c trap.c
> >       src/sys/arch/x86/x86: bus_dma.c cpu.c platform.c
> >
> > Log Message:
> > #ifdef - #endif-ed. NMCA, NISA, NNPX, NIOAPIC, LAPIC, MPBIOS and 
> Please, add no new #ifdefs.  Let config(1) and the linker configure the
> kernel.

That's a nice theory. In all likelihood most of these ifdefs are
required to make the system compilable when one or more of these
config items is turned off, and "fixing" it is not likely

Possibly true.

But as I have shown in a separate thread, it is now no longer possible to build an amd64 system with MULTIPROCESSOR but without MPBIOS. This is something that has previously worked just fine, and is implied by the comments in amd64/conf/GENERIC as valid configuration.

I have submitted separate patch (on current-users) to fix this specific situation, but who knows how many more previously-working combinations are now broken due to these changes?

| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
| Kernel Developer |                          | pgoyette at  |

Home | Main Index | Thread Index | Old Index