Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: othersrc/external/bsd/mat

On Mon, Nov 26, 2012 at 04:23:47PM +0100, Marc Balmer wrote:
> memwrite() can return with the file still being mapped (successful
> mmap(), then a short write).  Is that intended?  No big problem if
> the calling program exits when memwrite() returns 0, but I did not
> check that.

Yeah, you're right; I have more changes to come with the error
handling part of this, so this will be addressed along with the
others.  Thanks for keeping me honest, much appreciated.
> Then different formats are uses to print the size, "%u" in one case,
> "%" PRlu64 "" in the second case.  Could be nicer if it was
> consistent, maybe.

Ah, yes. I will fix - thanks.

Home | Main Index | Thread Index | Old Index