Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys

On Sat, Oct 13, 2012 at 11:35:56AM -0400, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date:         Sat Oct 13 15:35:56 UTC 2012
> Modified Files:
>       src/sys/kern: kern_exec.c
>       src/sys/sys: sysctl.h
> Log Message:
> add KERN_USRSTACK (this is not dynamically defined for FreeBSD compatibility)

This is wrong in multiple ways:
(1) Why do we care about FreeBSD compatibility? The existing code is
pretty much useless and should just die already. There is no support for
anything modernish anyway.

(2) It shouldn't be under kern in first place, it is about the current
process after all. I could see some possible sense in making it possible
to read it for arbitrary processes for light debugging, but that is
questionable either.

(3) The information is already available via libpthread and AT_STACKBASE
when processing the aux vector directly.

As such, I ask for reverting this.


Home | Main Index | Thread Index | Old Index