Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/ic

On Wed, Aug 29, 2012 at 06:23:37PM +0100, David Laight wrote:
> On Wed, Aug 29, 2012 at 04:50:10PM +0000, Jonathan A. Kollasch wrote:
> > Log Message:
> > mvsata(4) DMA data structures are already __packed, but as the hardware
> > requires them to be 8-byte aligned, add __aligned(8) too, so that accesses
> > on strict alignment platforms are more efficent.
> Sounds like it would be better to remove the overall __packed and use
> explicit __aligned(n) on the members that are not correctly aligned.

That seems much more prone to error, and also may not necessarily
produce a proper sizeof().

        Jonathan Kollasch

Home | Main Index | Thread Index | Old Index