Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/share/mk

On Tue, Aug 14, 2012 at 03:48:19PM +0200, Joerg Sonnenberger wrote:
 > On Mon, Aug 13, 2012 at 08:55:33PM +0000, David Holland wrote:
 > > On Fri, Aug 10, 2012 at 04:34:23PM +0000, Joerg Sonnenberger wrote:
 > >  > Modified Files:
 > >  >         src/share/mk:
 > >  > 
 > >  > Log Message:
 > >  > Remove effectively tautological condition.
 > > 
 > > I object to this sort of change. There are a number of other compilers
 > > we might want to try sometime; all you're doing is adding to the
 > > amount of work that takes.
 > Given the state of most of the conditions we had in the tree, it is not
 > a regression. If you have a compiler that doesn't provide most of the
 > GCC command line, you will have so much things to change that this is
 > irrelevant.

Perhaps so; all the same, it's creating extra work for no reason. I'm
not going to demand you revert the changes you've already made, but
please don't do it any more.

Perhaps we should create a new set of make variables called
HIDE_WARNINGS_* for the common cases that appear in these
conditionals, since there's only a handful of them that repeat over
and over again. Then the conditional logic itself can be centralized.

David A. Holland

Home | Main Index | Thread Index | Old Index