Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/sys/arch/sparc

On Aug 2,  4:22am, (matthew green) wrote:
-- Subject: re: CVS commit: src/sys/arch/sparc

| how can you say that commiting untsted code to sparc initialisation
| is the right thing?  there's absolutely nothing in the above statement
| (or any part of tiering) that supports this, nor has it ever been an
| OK thing to do in our community.

It was a judgement call. I thought that it has a good chance to work.
I was wrong.

| IMO, the right fix for you to get past the build problem originally
| would have been to disable -fno-common on sparc and file a PR.

Or just file a PR instead. I don't like adding kludges that would
certainly require undoing.


Home | Main Index | Thread Index | Old Index