Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/sys/dev/usb

> > Module Name:        src
> > Committed By:       christos
> > Date:               Fri Jul 20 02:23:35 UTC 2012
> > 
> > Modified Files:
> >     src/sys/dev/usb: usb.c
> > 
> > Log Message:
> > don't access memory outside the array bounds.
> and again, we have someone commiting code to usb.c that is wrong
> in the same way without asking anyone about it, in less than 3
> days...
> it is broken currently but there is a real fix in the works.
> please revert this.  keep a local patch if you need it, for now.

actually, after considering this change for a while i've determined
that the serialisation necessary for reading task->active must be
provided by the caller (ie, owner of task), and that we can check
the taskq after this.

there are still other problems to fix, but this change is OK.

sorry for over-reacting.


Home | Main Index | Thread Index | Old Index