[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src
Mindaugas Rasiukevicius wrote:
> Simon Burge <simonb%NetBSD.org@localhost> wrote:
> > > [ ... ]
> > >
> > > Log Message:
> > >
> > > Add MurmurHash2 -- a non-cryptographic hash function by Austin Appleby.
> > > The code is taken from the upstream and is in the public domain.
> > I'm curious why you've chosen MurmurHash2 instead of MurmurHash3 given the
> > known problems with MurmurHash2? Also, should the filename have a "2" in
> > it?
> It meets my needs.
What are your needs? I don't see this change discussed anywhere.
> Are you referring to the weakness when using 4-bytes?
> Anyway, that is why the file name does not have 2 in it, so that we could
> add MurmurHash3 as well.
That's completely different to the other hashes we have in the source
tree. Can you rename the file so that it's consistent please?
Main Index |
Thread Index |