Re: CVS commit: src/sys/common/pmap/tlb

[David Laight <david%l8s.co.uk@localhost>]

On Thu, Jul 05, 2012 at 10:34:00AM -0700, Matt Thomas wrote:
> 
> On Jul 5, 2012, at 10:25 AM, David Laight wrote:
> 
> > On Thu, Jul 05, 2012 at 05:24:54PM +0000, Matt Thomas wrote:
> >> Module Name:       src
> >> Committed By:      matt
> >> Date:              Thu Jul  5 17:24:54 UTC 2012
> >> 
> >> Modified Files:
> >>    src/sys/common/pmap/tlb: pmap.h pmap_segtab.c
> >> 
> >> Log Message:
> >> Change seg_tab to seg_ptr and make it a void * from a pt_entry_t * since it
> >> also needs to point to struct pmap_segtab * when used in a 3-level page 
> >> table.
> > 
> > Maybe a union instead?
> 
> I used a union previously and is was more bother than it was worth.

I was thinking of a union for the pointer, not of pt_entry_t and
struct pmap_segtab themselves.

Unqualified 'void *' are a PITA (when they don't just mean 'buffer').

        David

-- 
David Laight: david%l8s.co.uk@localhost