Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/xen/xenbus


It seems that this change makes the first vif of domU not recognized
when multiple vif's are assigned in config file.

For example, when config has
vif = [ 'mac=mac0, bridge=bridge0',
        'mac=mac1, bridge=bridge1',
        'mac=mac2, bridge=bridge2 ]

, you can see on domU
xennet0, whose mac is mac1,
xennet1, whose mac is mac2.

I see this problem on i386pae as domU running on amd64 as dom0.

On Tue, 5 Jun 2012 10:58:57 +0000
"Stephen Borrill" <> wrote:

> Module Name:  src
> Committed By: sborrill
> Date:         Tue Jun  5 10:58:57 UTC 2012
> Modified Files:
>       src/sys/arch/xen/xenbus: xenbus_probe.c
> Log Message:
> Sort vif and vbd device IDs numerically so that attach order does not depend
> on the order they are passed in through xenstore. While this works for
> hand-crafted Xen configuration files, it does not work for XenServer, XCP or
> EC2 instances. This means that adding an extra virtual disk can make the
> domU unbootable.
> ID is actually based on the Linux device major/minor so this approach isn't
> entirely correct (for instance, you can specify devices to be non-contiguous
> which doesn't fit too well with our autoconf approach), but it works as a
> first approximation.
> Tested by me on XenServer and riz@ on EC2. OK bouyer@
> To generate a diff of this commit:
> cvs rdiff -u -r1.35 -r1.36 src/sys/arch/xen/xenbus/xenbus_probe.c
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.


Home | Main Index | Thread Index | Old Index