Re: CVS commit: src/sys/arch/amd64/amd64

[Jean-Yves Migeon <jeanyves.migeon%free.fr@localhost>]

Le 21/04/12 23:25, Christos Zoulas a écrit :
> In article<4F930A8C.6040409%free.fr@localhost>,
> Jean-Yves Migeon<jeanyves.migeon%free.fr@localhost>  wrote:
> > Le 21/04/12 20:52, Christos Zoulas a écrit :
> > > Module Name:    src
> > > Committed By:   christos
> > > Date:           Sat Apr 21 18:52:37 UTC 2012
> > >
> > > Modified Files:
> > >         src/sys/arch/amd64/amd64: vector.S
> > >
> > > Log Message:
> > > Alignment fault traps push the error code automatically, so don't use
> > ZTRAP!
> >
> > Meh, the fix was awaiting Paul testing... Alright, so I guess this one
> > is right.
>
> Even if Paul's testing discovered that the fix did not work for the emulator,
> wouldn't you commit it so that at least things work on real hardware?

It's the other way around; the bug was rather harmless in VMs (kills the 
process with a SIGILL), while it force-reboot the host on a native platform.

I could not know that the fix works on real hardware, that's why I was 
waiting for Paul's response.

> > Do you want me to ask for a pull-up?
>
> Sure, thanks.

Will do.

--
jym@