Re: CVS commit: src/lib/libc/gen

[Alan Barrett <apb%cequrux.com@localhost>]

On Thu, 22 Mar 2012, Havard Eidnes wrote:
> Module Name:    src
> Committed By:   he
> Date:           Thu Mar 22 13:42:36 UTC 2012
>
> Modified Files:
>         src/lib/libc/gen: nlist_coff.c
>
> Log Message:
> Make this lint-free (only built for real for the __sh__ ports):
> * Mark some code after goto as /* NOTREACHED */
> * Add a cast for file size (off_t) to size_t to avoid warning about
>   possibly losing bits.
> * Avoid a "pointer casts may be troublesome" warning from lint
>   by doing a cast via "void *" instead of directly to "struct
>   coff_filehdr *".

If off_t is larger than size_t, then casting will hide a potential bug
where the file size is too large to be represented by a size_t value.

--apb (Alan Barrett)