Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sbin/ifconfig



On Sun, Mar 18, 2012 at 05:08:44PM +0200, Jukka Ruohonen wrote:
 > All good; exited without nothing printed to stderr and the status is zero.
 > But this:
 > 
 >      atf_check -o ignore \
 >              -s exit:0 -x "find /etc -type f -exit"
 > 
 > yields
 > 
 >      tc-so:Executing command [ /bin/sh -c find /etc -type f -exit ]
 >      tc-se:Fail: incorrect exit status: 1, expected: 0
 >      tc-se:stdout:
 >      tc-se:
 >      tc-se:stderr:
 >      tc-se:find: fts_read: Inappropriate ioctl for device
 >      tc-se:
 >      tc-end: 1332083101.965143, exit, failed, atf-check failed;
 >      see the output of the test for details
 > 
 > So what is going on here?

As njoly posted in the PR it looks as if redirecting stdin from
/dev/null causes something to be left in errno that find then prints
as per the PR.

With the fix I just committed it doesn't do this, so I think we can
(1) declare the PR fixed and (2) conclude that the behavior you're
seeing isn't atf's fault.

-- 
David A. Holland
dholland%netbsd.org@localhost


Home | Main Index | Thread Index | Old Index