Re: CVS commit: src/sys/arch

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Sat, Feb 25, 2012 at 10:30:30AM +0530, Cherry G. Mathew wrote:
> I've made a few changes to pmap.c where it looks harmless to do so,
> but are in favour of consistency.
> ftp://ftp.netbsd.org/pub/NetBSD/misc/cherry/tmp/xen-set-pte.diff

Did you test it ? I have a vague memory that using spl() in early
allocation routines would cause a trap (maybe because curcpu() doesn't
work yet) but maybe your recent changes fixed it.
Also you can change
#ifndef XEN
       const pd_entry_t pteflags = PG_V | PG_RW;
#else /* XEN */
       const pd_entry_t pteflags = PG_u | PG_V | PG_RW;
#endif /* XEN */

to:
        const pd_entry_t pteflags = PG_k | PG_V | PG_RW;

(PG_k is defined to PG_u on Xen/amd64 and 0 otherwise).

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--