Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/usr.sbin/crash



On Feb 19,  6:43am, mrg%eterna.com.au@localhost (matthew green) wrote:
-- Subject: re: CVS commit: src/usr.sbin/crash

| 
| > I thought arm works. I am fixing mvme68k now. I am trying to make things
| > work without the kludge that is why I left it broken.
| 
| can you please not do this?  ie, don't commit broken code and leave
| the tree broken for random ports for some time.  if you see a break
| that isn't trivial to fix, please just revert your change.

I have fixed everything already. While I have built all the toolchains
and it is easy for me to build one arch at the time I don't have the space
to build all.

| (i'm not even convinced that making crash/Makefile "clean" is worth
| all the code churn involved, espcially with cvs as our back end that
| doesn't cope well with moved files.)

It is not much churn at all; crash uses a small subset of db_interface.c
and it is not worth it ifdef'ing it all over the place and not understanding
what gets compiled or not.

| it's really annoying when you try to build netbsd and it doesn't
| for these sorts of reasons.  i've wasted a bunch of hours just in
| the last week dealing with failed build points when trying to
| binary search a failure point.

It was just broken for 2 days, because I could not get build results
quicker.

christos


Home | Main Index | Thread Index | Old Index