Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src



On Sun, Feb 12, 2012 at 10:53:56AM +0100, Martin Husemann wrote:
> >     tests/sys/kern/t_module.c
> >     ...
> and
>         test/sys/kern/posix_spawn/*
> 
> I don't mind moving it there, if there is consensus. We can clean other stuff
> later. I don't like mixing it with tons of unrelated tests in a common 
> directory though.

As said, please follow the libc-structure, as it is the current convention;

        libc/sys -> tests/lib/libc/sys
        libc/gen -> tests/lib/libc/gen

        and also

        lib/librt -> tests/lib/librt

        even though majority of this stuff is implenented inside the kernel.

There is also a more philosophical argument; unit tests like this should not
care what the implementation is or where it resides -- you are testing the
POSIX interface, so the logical place is the "user visible frontend", not
where it might be implemented. For comparable reasons, we put manual pages
to the libc directory structure, not to sys/kern.

- Jukka.


Home | Main Index | Thread Index | Old Index