Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/kern



On Tue, Jan 31, 2012 at 07:11:38PM +0000, Alexander Nasonov wrote:
> Module Name:  src
> Committed By: alnsn
> Date:         Tue Jan 31 19:11:38 UTC 2012
> 
> Modified Files:
>       src/sys/kern: subr_pcq.c
> 
> Log Message:
> Replace offsetof(pcq_t, pcq_items[nitems]) with sizeof(pcq_t) + sizeof(void 
> *[nitems]).

Yuck. The offsetof() way was much more readable.  Please put it back
the old way.  If you have to, provide and use a runtime_offsetof() that
DTRT.

Dave

-- 
David Young
dyoung%pobox.com@localhost    Urbana, IL    (217) 721-9981


Home | Main Index | Thread Index | Old Index