Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/ic


On Thu, 12 Jan 2012 18:19:26 +0900
Izumi Tsutsui <> wrote:

> > Module Name:        src
> > Committed By:       macallan
> > Date:               Wed Jan 11 20:41:28 UTC 2012
> > 
> > Modified Files:
> >     src/sys/dev/ic: igsfb.c vga.c vga_raster.c
> > 
> > Log Message:
> > wsfont_matches() and wsfont_find() take an extra parameter now
> Isn't it possible to provide compatible wrapper functions (without
> an extra parameter) rather than changing all existing API callers?
> So that you don't have to bump kernel version for modular(7) and
> all third parties (including ongoing porting efforts) don't
> have to fix their drivers on updating code base.

That would be trivial to do. The reason I didn't do it right away was that I 
had no idea there were so many drivers that call wsfont_find() - at least that 
shouldn't be necessary anymore in most cases, now that rasops_init() at least 
tries to pick a sensible font for the screen / terminal size requested. In vga 
it makes sense ( in order to get an 8 pixels wide font and nothing else ), in 
igsfb not so much.
Also, I'm not aware of any modular wsdisplay drivers.

have fun

Home | Main Index | Thread Index | Old Index