Re: CVS commit: src/sys/arch

[David Holland <dholland-sourcechanges%netbsd.org@localhost>]

On Fri, Jan 06, 2012 at 03:15:28PM +0000, Cherry G. Mathew wrote:
 > Modified Files:
 >      src/sys/arch/x86/x86: pmap.c
 >      src/sys/arch/xen/x86: cpu.c
 > 
 > Log Message:
 > Address those pesky DIAGNOSTIC messages. \n
 > Take a performance hit at fork() for not DTRT. \n
 > Note: Only applicable for kernels built with "options DIAGNOSTIC" \n
 >
 > [...]
 > +#ifdef DIAGNOSTIC
 > +               pmap_kremove(object, PAGE_SIZE);
 > +#endif /* DIAGNOSTIC */
 > [plus two more like that]

Uh... even if that's correct, which doesn't seem too likely on the
surface of things, it doesn't seem desirable.

-- 
David A. Holland
dholland%netbsd.org@localhost