Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/external/bsd/atf/dist/atf-run

On 12/19/11 10:25 PM, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date:         Mon Dec 19 22:25:46 UTC 2011
> Modified Files:
>       src/external/bsd/atf/dist/atf-run: timer.cpp
> Log Message:
> - make all the ifdefs match
> - make it compile, and test

This was still broken.

timer_t and itimerspec do not exist, so the timer.hpp file is unusable.
 The definition of HAVE_POSIX_TIMER does not work because SIGEV_NONE is
defined in OS X.  The change of sys/time.h and signal.h to ctime and
csignal seems to cause issues too.

I have had to fix this by adding a configure test for timer_t, using the
pimpl idiom for the timer class definition to prevent further ifdef mess
in timer.hpp, and had to sprinkle some more ifdef stuff in the code.

The result is incredibly ugly, and I doubt there is any real benefit
other than "using modern interfaces".  Was it really worth it?  (I have
not committed these "fixes" to the NetBSD tree because I cannot test
them at the moment.)

Julio Merino / @jmmv

Home | Main Index | Thread Index | Old Index