Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/lib/libc/string



On Fri, Nov 25, 2011 at 12:57:29PM +0000, David Holland wrote:
> On Fri, Nov 25, 2011 at 01:01:34PM +0100, Joerg Sonnenberger wrote:
>  > > Log Message:
>  > > Add explicit casts to make lint happy and fix the NetBSD/i386 build.
>  > 
>  > Can we please just get rid of this PoS? This doesn't even qualify as bad
>  > signal to noise ratio.
> 
> Sure it does. You should just have written the code using (size_t)1,
> or even just 1UL, instead of 1ULL. There is no port where size_t is
> unsigned long long.
> 
> ... Unless what you meant was "get rid of all 32-bit ports" :-)

Well, there is Win64 and this is essentially portable code...

Joerg


Home | Main Index | Thread Index | Old Index