Re: CVS commit: src/sys/sys

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Mon, Nov 21, 2011 at 03:27:55AM +0000, Christos Zoulas wrote:
> In article <20111120235018.GA32252%britannica.bec.de@localhost>,
> Joerg Sonnenberger  <joerg%britannica.bec.de@localhost> wrote:
> >On Sun, Nov 20, 2011 at 06:37:00PM -0500, Christos Zoulas wrote:
> >> Module Name:       src
> >> Committed By:      christos
> >> Date:              Sun Nov 20 23:37:00 UTC 2011
> >> 
> >> Modified Files:
> >>    src/sys/sys: aio.h buf.h kernhist.h lockdebug.h lwp.h malloc.h mbuf.h
> >>        module.h mqueue.h namei.h pool.h sched.h sleepq.h vmem.h vnode.h
> >>        wapbl.h
> >> 
> >> Log Message:
> >> add more missing printf attributes.
> >
> >Please use __printflike.
> 
> Well, the rest of the sys files don't, so I followed suit.

They are not consistent, which is a bug. There should be no plain
__attribute__s in the tree except 3rd party code.

Joerg