[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/external/bsd/atf/dist
On 11/16/11 1:51 PM, Christos Zoulas wrote:
Julio Merino<jmmv%NetBSD.org@localhost> wrote:
On 11/16/11 12:46 PM, Christos Zoulas wrote:
Module Name: src
Committed By: christos
Date: Wed Nov 16 17:46:16 UTC 2011
src/external/bsd/atf/dist/atf-c++/detail: text.cpp text.hpp
src/external/bsd/atf/dist/atf-run: requirements.cpp test-program.cpp
PR/45619: jmmv: Allow atf tests to request a minimum amount of memory
Could you run intrusive changes to atf for review please?
The current changes are incomplete and inappropriate, so they are going
to make integration upstream a pain.
Well, there is really no portable way to find the total available memory of
the system that I know of and I did not want to add ifdefs or machinery
to get this working on other OS's. If you know otherwise, feel free to fix it.
I know there is no portable way, but at least we can default to "do
nothing" if this is not supported. It's better than "not building" :-P
The changes are really small and they are additions only. I fail to see how
it is going to be difficult to integrate.
Yes, they are small because this is just one change. But more may come.
I'll then have to go and rewrite all these local changes with
portability in mind. When the time to integrate a new release comes,
I'll have to mess around with lots merge conflicts, because the upstream
code will look nothing like what we have (hence why I asked for this to
be reviewed first).
Of course, if we assume I keep good track of all local changes and
integrate them upstream (I do try), I could ignore the local changes
altogether during the conflicts resolution and use the upstream
copies... but that's... dangerous because I can miss some little thing.
Specially if the local changes are made without tests, because then
it'll be impossible for me to spot when such changes are not preserved.
Main Index |
Thread Index |