Re: CVS commit: src/external/bsd/atf/dist/atf-c

[Julio Merino <jmmv%NetBSD.org@localhost>]

On 11/8/11 3:25 PM, Christos Zoulas wrote:
> In article <20111107202432.GA7502%britannica.bec.de@localhost>,
> Joerg Sonnenberger  <joerg%britannica.bec.de@localhost> wrote:
>> On Mon, Nov 07, 2011 at 04:06:30PM +0000, Christos Zoulas wrote:
>>> Well, I tried to print the failing pattern in t_expand, and it silently
>>> got truncated. dprintf(3) has been part of TOG since 2006:
>>> (http://pubs.opengroup.org/onlinepubs/9699919799/functions/dprintf.html)
>>> So it would be preferable to implement it in terms of asprintf/write +
>>> or snprintf/malloc/write or even fdopen/fprintf instead of open coding it.
>>
>>From reading the patch, there are three different brances, right?
>> Why don't you use writev for this with up to 6 elements in the vector?
> 
> Done.

Did you even run any tests after doing this?

This is broken.  The assertion you added triggers immediately.

-- 
Julio Merino / @jmmv