Re: CVS commit: src/lib/libutil

[christos%zoulas.com@localhost (Christos Zoulas)]

On Nov 2,  7:11am, netbsd%lists.veego.de@localhost (Bernd Ernesti) wrote:
-- Subject: Re: CVS commit: src/lib/libutil

| Hi,
| 
| On Thu, Oct 20, 2011 at 09:37:59PM -0400, Christos Zoulas wrote:
| > Module Name:        src
| > Committed By:       christos
| > Date:               Fri Oct 21 01:37:59 UTC 2011
| > 
| > Modified Files:
| >     src/lib/libutil: Makefile
| > 
| > Log Message:
| > Don't use = to assing SRCS, but += so that we can remove snprintb.c,
| > which was added elsewhere.
| 
| I find that a little dangerous.
| 
| Now SRCS could be defined in the environment which may cause
| different behaviour like including different not wanted source
| file, build errors ...
| 
| I do not know if it would work to move the include of the common
| Makefile.inc at the end, propably not. And yes the common Makefile.inc
| already used SRCS+= before. That alone should require to move
| that include after a normal SRCS=

It would probably work, and if you think it is better, go ahead and do it.
There is a whole bunch of variables that is set and passed between Makefiles
and the environment... For example what happens if you set CC? or CFLAGS?
or...

christos