Re: CVS commit: src/sys/arch/x86/x86

[Paul Goyette <paul%whooppee.com@localhost>]

On Tue, 18 Oct 2011, Jukka Ruohonen wrote:

> On Tue, Oct 18, 2011 at 06:39:49AM -0400, Jared McNeill wrote:
> > I would argue that any manually loaded module shouldn't be autounloaded.
> > What do you think about flagging modules as autoloaded and only
> > autounloading the autoloaded ones?
>
> That sounds right to me.

I was under the impression that we would already only auto-unload 
modules that were auto-loaded.  The comment in module_thread() says

 *      Automatically unload modules.  We try once to unload autoloaded
 *      modules after module_autotime seconds.  ...

module_thread() skips modules with mod->mod_autotime of zero, and at the 
end of module_do_load() we have

        if (autoload) {
                /*
                 * Arrange to try unloading the module after
                 * a short delay.
                 */
                mod->mod_autotime = time_second + module_autotime;
                module_thread_kick();
        }

So mod->mod_autotime is only set if the module was autoloaded.


-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------