Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src



On Thu, Sep 29, 2011 at 10:56:48PM +0100, Alexander Nasonov wrote:
> Elements must go in descendant order but since values of
> CPUFREQ_STATE_DISABLED and CPUFREQ_STATE_ENABLED are unspecified,
> the manual should explicitly state in which order these two states
> should go.

True.

> Every time you skip cf->cf_state element, you have a gap in the

Oh, true.

> The documentation is clear about cf_state elements, why do you need
> to skip entries at all and make your life harder? Just return error
> or add KASSERT if a caller doesn't follow the docs.

I moved it here so that code can be shared. This must be done somewhere for
things that rely on firmware for the values; any kind of garbage can follow,
but you don't want to abort the whole thing due a single mistake done by the
BIOS writer.

- Jukka.


Home | Main Index | Thread Index | Old Index