Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/etc/mtree



In article <20110906150225.GC16168%apb-laptoy.apb.alt.za@localhost>,
Alan Barrett  <apb%cequrux.com@localhost> wrote:
>On Tue, 06 Sep 2011, Christos Zoulas wrote:
>>>> Modified Files:
>>>>    src/etc/mtree: Makefile
>>>>
>>>> Log Message:
>>>> Use ${.OBJDIR}/NetBSD.dist.tmp instead of just NetBSD.dist.tmp.
>>>> This fixes a problem in which NetBSD.dist.tmp had been created in
>>>> the SRCDIR by an earlier build (performed without an OBJDIR), and
>>>> the existence of the file in the SRCDIR confused a subsequent build
>>>> (performed with an OBJDIR).
>>
>> We definitely don't want to add such magic. Please 
>> revert. Otherwise we should go and do this in 100's of 
>> Makefiles.
>
>I certainly see no reason to make similar changes in hundreds of 
>Makefiles; only in the few places where people actually encounter 
>(and report) problems traceable to this sort of issue.  There have 
>been only a few such issues, and we have fixed all the others 
>(elsewhere under src/etc).

Out of 5565 Makefiles in the source tree only 77 mention .OBJDIR and
from a cursory glance most of the uses are bogus/can be avoided.

christos



Home | Main Index | Thread Index | Old Index