Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src

On Wed, 31 Aug 2011, Warner Losh wrote:

> In the absence of both the prototype and a cast, NULL (which can be 0)
> will be passed as an int, not as a pointer.

NetBSD C headers define NULL as ((void *)0), and our Makefiles use -Wall
(includes -Wimplicit-function-declaration) to avoid such situations..

> Given that NetBSD's charter is to create portable code, reverting the
> variadic function argument cast removal seems the most portable thing to
> do.

Ok I have reviewed the patch and reinstated the NULL casts, where it was
being passed as a vararg. Any other situations?

Jörg or Valeriy; please fix share/misc/style


Home | Main Index | Thread Index | Old Index