Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/external/bsd/mdocml

On Fri, Aug 19, 2011 at 10:57:53AM -0400, Jim Wise wrote:
> And the project has a long history of making sure all (these days: most)
> code in the base distribution builds with -Wall -Werror.  This isn't
> because every GCC warning is right, of course -- it's because when you
> turn off warnings for a whole file, you risk hiding another warning
> which _is_ a sign of an actual code problem.

When have you last checked the number of -Wno-* instances in base?
Sorry, but pessimizing code to work around clearly bogus GCC warnings is
not helpful. It doesn't make code easier to read, it doesn't improve
code quality. It's the same kind of behavior that results in
isalpha((int)ch) code.


Home | Main Index | Thread Index | Old Index