Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: src/sys/modules/spdmem

On Fri, 19 Aug 2011, David Holland wrote:
I think we should make no changes to appease the compiler in
this case. [...]

I would lean towards fixing the ones that can be fixed
noninvasively; [...]

The compiler is being really stupid, and I don't like making invasive changes to appease it. Non-invasive changes are fine, such as adding CFLAGS.filename += -Wno-stupid-warning to a Makefile, or changing a const variable to a #define.

If it helped, then it would also be fine to change
    const char * format = "%s";
    const char * const format = "%s";
but it doesn't help.

--apb (Alan Barrett)

Home | Main Index | Thread Index | Old Index