Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.sbin/wlanctl

In article <>,
David Young  <> wrote:
>On Tue, Aug 16, 2011 at 04:33:46AM -0400, Christos Zoulas wrote:
>> Module Name: src
>> Committed By:        christos
>> Date:                Tue Aug 16 08:33:46 UTC 2011
>> Modified Files:
>>      src/usr.sbin/wlanctl: wlanctl.c
>> Log Message:
>> avoid non-literal format strings
>What's the purpose of this change, to quiet compiler warnings?  The old
>code looked correct to me.  Wasn't it?  I had purposefully not repeated
>the printf()s because I thought that it showed the intention of the code

This is a close call case, I chose to appease the compiler and have it
check the format, instead of not checking it.

>In principle, at least, the compiler should have been able to tell that
>the old code was safe.  Can't it?

Apparently not (yet).


Home | Main Index | Thread Index | Old Index