[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/kern
> On Wed, Aug 10, 2011 at 03:10:13AM +0000, YAMAMOTO Takashi wrote:
> > > Log Message:
> > > Fail namei immediately if searchdir is unlinked / has been rmdir'd.
> > > Do this by checking if v_size == 0. Should fix PR 44658 (and PR 32661).
> > why is this necessary? can't we just let VOP_LOOKUP fail?
> Not to fix PR 44658.
it's better to fix the vn_isunder check instead of avoiding running it.
IMO vn_isunder should return acutal error code (eg. ENOENT) rather
than just a boolean so that callers can decide what to do.
> > the v_size == 0 check sounds wrong. does it work for eg. nfs?
> It apparently does break nullfs, so I've reverted it.
> Is there any way to check this correctly/safely above the filesystem?
if "above the filesystem" means "without calling VOPs", i don't think
there's a way.
> David A. Holland
Main Index |
Thread Index |