Re: CVS commit: src/lib/libedit

[christos%astron.com@localhost (Christos Zoulas)]

In article <20110730064751.GA19272%apb-laptoy.apb.alt.za@localhost>,
Alan Barrett  <apb%cequrux.com@localhost> wrote:
>On Fri, 29 Jul 2011, Christos Zoulas wrote:
>>Log Message:
>>add -Wunused-parameter
>>Is that the right way? Perhaps WARNS=5?
>
>Or add -Wunused-parameter to WARNS=4.
>
>WARNS levels should be organised by the ease of avoiding or fixing the
>warnings; there's no need to add a new level for each warning.

-Wunused-parameters and -Wconversion typically need annotations and casts
to be fixed that are controvercial. Actually -Wconversion seems to be broken
right now, as it complains about valid code. We should not be forcing them
down people's throats.

christos