re: CVS commit: src/sys/arch/alpha/include

[matthew green <mrg%eterna.com.au@localhost>]

> On Sun, Jul 17, 2011 at 03:33:56PM +1000, matthew green wrote:
> > 
> > > Module Name:      src
> > > Committed By:     dyoung
> > > Date:             Sun Jul 17 01:08:12 UTC 2011
> > > 
> > > Modified Files:
> > >   src/sys/arch/alpha/include: sysarch.h
> > > 
> > > Log Message:
> > > Don't #include <machine/bus_defs.h> from this header unless _KERNEL
> > > is #defined.  While this header is installed in the alpha userland,
> > > however, <machine/bus_defs.h> is not.
> > > 
> > > Don't declare any of the alpha_bus_ or alpha_pci_ symbols unless _KERNEL
> > > is #defined.  I cannot find anything but libarch in the base system
> > > that uses the symbols.  Anything using alpha_pci_ symbols ought to use
> > > pci(3), instead.  Up next: don't use those symbols in libarch.
> > 
> > what makes you think that libalpha isn't used?  it sure does
> > sem to be to me:
> > 
> > src/external/mit/xorg/server/xorg-server/hw/vfb/Makefile:106:DPADD+=      
> > ${LIBALPHA}
> > src/external/mit/xorg/server/xorg-server/hw/xnest/Makefile:109:DPADD+=    
> > ${LIBALPHA}
> > src/external/mit/xorg/server/xorg-server/hw/xfree86/Xorg/Makefile:75:DPADD+=
> >       ${LIBALPHA}
> > src/external/mit/xorg/server/xorg-server/hw/xfree86/utils/ioport/Makefile:30:DPADD+=
> >       ${LIBALPHA}
> > src/external/mit/xorg/server/xorg-server/hw/xfree86/utils/pcitweak/Makefile:28:DPADD+=
> >     ${LIBALPHA}
> > src/external/mit/xorg/server/xorg-server/hw/xfree86/utils/scanpci/Makefile:31:DPADD+=
> >      ${LIBALPHA}
> 
> Hadn't searched the X11 sources.  Can't libpci replace many of the
> libalpha uses?

i'm not sure, but please revert your change until we figure this out.
making port-alpha build by simply removing what isn't building is the
wrong answer, unless you're positive that is the right thing to do.
even if X11 didn't use libalpha, what about potential 3rd party code?

please contact port-alpha about this, or perhaps file a PR against
port-alpha if you do not have time to look at it properly.  thanks.


.mrg.

ps: port-shark kernels don't build right now.  can you please have a
look?  thanks.