Re: CVS commit: src/sys/uvm

[Masao Uebayashi <uebayasi%gmail.com@localhost>]

On Tue, Jun 28, 2011 at 9:39 AM, YAMAMOTO Takashi
<yamt%mwd.biglobe.ne.jp@localhost> wrote:
> hi,
>
>> Module Name:  src
>> Committed By: hannken
>> Date:         Mon Jun 27 15:56:37 UTC 2011
>>
>> Modified Files:
>>       src/sys/uvm: uvm_amap.c
>>
>> Log Message:
>> amap_copy(): Keep the source amap locked until its lock has been copied.
>
> btw, this code seems to assume that uvm_anfree does not release the lock
> even temporarily while the comment on uvm_anfree1 says the opposite.

This locking protocol looks odd to me.  Mutex obj is alloc'ed in amap,
why not free'ed in amap too?  uobj is doing so.

>
> YAMAMOTO Takashi
>
>>
>> Kernel assertion "anon->an_lock == amap->am_lock" no longer fails.
>>
>> Ok: Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>
>>
>>
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.99 -r1.100 src/sys/uvm/uvm_amap.c
>>
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.
>